Subscribe to server out upon connection #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to clojure-emacs/cider-nrepl#266. Goes with clojure-emacs/cider-nrepl#267.
|
Looks good to me. I'm wondering if we should expose the ability to unsubscribe a session in CIDER. Probably few people would use this, so it doesn't make much sense. On the other hand it would make it possible to toggle between the old and new behaviour. This is definitely not important, I'm just jotting down some thoughts. |
bbatsov
added a commit
that referenced
this pull request
Oct 19, 2015
Subscribe to server out upon connection
If somebody asks for it, we can probably just tell them to do something like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to clojure-emacs/cider-nrepl#266.
Goes with clojure-emacs/cider-nrepl#267.