Skip to content

Conversation

Malabarba
Copy link
Member

  • cider-docview-file will tell the user that it can't find the file, instead of throwing a cryptic error.
  • cider-jump-to supports jumping to vars by name, besides position. This goes with a change in cider-nrepl which will provide us with the file even for variables whose origin we don't fully know (still, this commit is safe to merge on its own).
  • Small fix and a defgroup on cider-debug.

Fix unused variable in cider--make-result-overlay
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an empty line, it's a ^L.

@bbatsov
Copy link
Member

bbatsov commented Jul 1, 2015

cider-jump-to supports jumping to vars by name, besides position. This goes with a change in cider-nrepl which will provide us with the file even for variables whose origin we don't fully know (still, this commit is safe to merge on its own).

You should check that this works from stacktraces as well. Probably no extra changes are needed there, but still... better safe than sorry.

@Malabarba
Copy link
Member Author

I'll check stacktraces, I'll probably have to add a bit of code.

@Malabarba
Copy link
Member Author

Stacktraces now work as well. And I've added a commit.
Also clojure-emacs/cider-nrepl#223

@bbatsov
Copy link
Member

bbatsov commented Jul 1, 2015

Stacktraces now work as well.

Nice. I guess we can mark #1175 as fixed and update the changelog.

@Malabarba
Copy link
Member Author

Actually, I only tested that following buttons on Stack traces works, I forgot to test the highlighting. So don't close it just yet.

@Malabarba
Copy link
Member Author

I just tested, and no, this is not enough to make highlighting work. I'm adding a comment to that discussion, but it's mosly unrelated to this commit, I think.

@Malabarba
Copy link
Member Author

Reworded.

@bbatsov
Copy link
Member

bbatsov commented Jul 2, 2015

👍 Thanks!

bbatsov added a commit that referenced this pull request Jul 2, 2015
@bbatsov bbatsov merged commit c97ed64 into clojure-emacs:master Jul 2, 2015
@Malabarba Malabarba deleted the small-things-all-around branch July 2, 2015 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants