-
-
Notifications
You must be signed in to change notification settings - Fork 653
Small things all around #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small things all around #1180
Conversation
Fix unused variable in cider--make-result-overlay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an empty line, it's a ^L.
You should check that this works from stacktraces as well. Probably no extra changes are needed there, but still... better safe than sorry. |
I'll check stacktraces, I'll probably have to add a bit of code. |
Stacktraces now work as well. And I've added a commit. |
Nice. I guess we can mark #1175 as fixed and update the changelog. |
Actually, I only tested that following buttons on Stack traces works, I forgot to test the highlighting. So don't close it just yet. |
I just tested, and no, this is not enough to make highlighting work. I'm adding a comment to that discussion, but it's mosly unrelated to this commit, I think. |
Reworded. |
👍 Thanks! |
cider-docview-file
will tell the user that it can't find the file, instead of throwing a cryptic error.cider-jump-to
supports jumping to vars by name, besides position. This goes with a change in cider-nrepl which will provide us with the file even for variables whose origin we don't fully know (still, this commit is safe to merge on its own).