Allow jumping to source file,line and column for compilation errors

[tbatchelli]

When a compilation error happens, the error message from the compiler contains the file, line and column of the error. This appears on the stacktrace buffer, but I couldn't find any way to jump from the stacktrace to the actual error, as the offending source does not appear in any of the frames.

The feature request would be to identify compilation errors and get the information about the file and position within the file from the error message. Then turn that information into a link to the right buffer and position within the buffer.

Here is an example:

  Show: Clojure Java REPL Tooling Duplicates All  (47 frames hidden)

2. Unhandled clojure.lang.Compiler$CompilerException
   Error compiling:
   /Users/tbatchelli/dev/palletops/admin-user-crate/src/pallet/crate/admin_user/admin_user.clj:249:41

                 Compiler.java: 7137  clojure.lang.Compiler/load
                          REPL:    1  user/eval18774
                 Compiler.java: 6703  clojure.lang.Compiler/eval
                 Compiler.java: 6666  clojure.lang.Compiler/eval
                      core.clj: 2927  clojure.core/eval
                      main.clj:  239  clojure.main/repl/read-eval-print/fn
                      main.clj:  239  clojure.main/repl/read-eval-print
                      main.clj:  257  clojure.main/repl/fn
                      main.clj:  257  clojure.main/repl
                   RestFn.java: 1096  clojure.lang.RestFn/invoke
        interruptible_eval.clj:   56  clojure.tools.nrepl.middleware.interruptible-eval/evaluate/fn
                      AFn.java:  152  clojure.lang.AFn/applyToHelper
                      AFn.java:  144  clojure.lang.AFn/applyTo
                      core.clj:  624  clojure.core/apply
                      core.clj: 1862  clojure.core/with-bindings*
                   RestFn.java:  425  clojure.lang.RestFn/invoke
        interruptible_eval.clj:   41  clojure.tools.nrepl.middleware.interruptible-eval/evaluate
        interruptible_eval.clj:  171  clojure.tools.nrepl.middleware.interruptible-eval/interruptible-eval/fn/fn
                      core.clj: 2402  clojure.core/comp/fn
        interruptible_eval.clj:  138  clojure.tools.nrepl.middleware.interruptible-eval/run-next/fn
                      AFn.java:   22  clojure.lang.AFn/run
       ThreadPoolExecutor.java: 1145  java.util.concurrent.ThreadPoolExecutor/runWorker
       ThreadPoolExecutor.java:  615  java.util.concurrent.ThreadPoolExecutor$Worker/run
                   Thread.java:  745  java.lang.Thread/run

1. Caused by java.lang.RuntimeException
   Invalid token: sudoers/

                     Util.java:  221  clojure.lang.Util/runtimeException
               LispReader.java:  316  clojure.lang.LispReader/interpretToken
               LispReader.java:  209  clojure.lang.LispReader/read
               LispReader.java: 1147  clojure.lang.LispReader/readDelimitedList
               LispReader.java:  972  clojure.lang.LispReader$ListReader/invoke
               LispReader.java: 1138  clojure.lang.LispReader/readDelimitedList
               LispReader.java: 1081  clojure.lang.LispReader$MapReader/invoke
               LispReader.java: 1138  clojure.lang.LispReader/readDelimitedList
               LispReader.java: 1081  clojure.lang.LispReader$MapReader/invoke
               LispReader.java: 1138  clojure.lang.LispReader/readDelimitedList
               LispReader.java:  972  clojure.lang.LispReader$ListReader/invoke
               LispReader.java: 1138  clojure.lang.LispReader/readDelimitedList
               LispReader.java:  972  clojure.lang.LispReader$ListReader/invoke
               LispReader.java:  183  clojure.lang.LispReader/read
                 Compiler.java: 7126  clojure.lang.Compiler/load
                          REPL:    1  user/eval18774
                 Compiler.java: 6703  clojure.lang.Compiler/eval
                 Compiler.java: 6666  clojure.lang.Compiler/eval
                      core.clj: 2927  clojure.core/eval
                      main.clj:  239  clojure.main/repl/read-eval-print/fn
                      main.clj:  239  clojure.main/repl/read-eval-print
                      main.clj:  257  clojure.main/repl/fn
                      main.clj:  257  clojure.main/repl
                   RestFn.java: 1096  clojure.lang.RestFn/invoke
        interruptible_eval.clj:   56  clojure.tools.nrepl.middleware.interruptible-eval/evaluate/fn
                      AFn.java:  152  clojure.lang.AFn/applyToHelper
                      AFn.java:  144  clojure.lang.AFn/applyTo
                      core.clj:  624  clojure.core/apply
                      core.clj: 1862  clojure.core/with-bindings*
                   RestFn.java:  425  clojure.lang.RestFn/invoke
        interruptible_eval.clj:   41  clojure.tools.nrepl.middleware.interruptible-eval/evaluate
        interruptible_eval.clj:  171  clojure.tools.nrepl.middleware.interruptible-eval/interruptible-eval/fn/fn
                      core.clj: 2402  clojure.core/comp/fn
        interruptible_eval.clj:  138  clojure.tools.nrepl.middleware.interruptible-eval/run-next/fn
                      AFn.java:   22  clojure.lang.AFn/run
       ThreadPoolExecutor.java: 1145  java.util.concurrent.ThreadPoolExecutor/runWorker
       ThreadPoolExecutor.java:  615  java.util.concurrent.ThreadPoolExecutor$Worker/run
                   Thread.java:  745  java.lang.Thread/run

[jeffvalk]

Yep. I'd been meaning to get to this.

[bbatsov]

👍 That'd be a welcome improvement indeed.

[vspinu]

CIDER 7.0 should jump to that error automatically or with next error M-g n.

I think in the stacktrace the compilation message must be considered the first error, the top-frame in stack the second error, etc. The next-error-function must be moved from cider buffers into stacktrace buffer. Then you will be able to M-g n .. M-g n from any clojure buffer without explicitly going through stacktrace buffer.

[tbatchelli]

Doesn’t next-error only work on a per-buffer basis? What I mean by this is that the compilation error might be on a different buffer than the one I am compiling

—

Antoni Batchelli,

• twitter: @tbatchelli , @disclojure
  --- email: tbatchelli@gmail.com
  ----- web: tbatchelli.org , disclojure.org
  ----- gpg: public key

From: Vitalie Spinu notifications@github.com
Reply: clojure-emacs/cider reply@reply.github.com>
Date: August 7, 2014 at 1:24:57 PM
To: clojure-emacs/cider cider@noreply.github.com>
Cc: Antoni Batchelli tbatchelli@acm.org>
Subject:  Re: [cider] Allow jumping to source file,line and column for compilation errors (#715)

CIDER 7.0 should jump to that error automatically or with next error M-g n.

I think in the stacktrace the compilation message must be considered the first error, the top-frame in stack the second error, etc. The next-error-function must be moved from cider buffers into stacktrace buffer. Then you will be able to M-g n .. M-g n from any clojure buffer without explicitly going through stacktrace buffer.

—
Reply to this email directly or view it on GitHub.

[bbatsov]

It works across buffers - as long as the related compilation buffer is opened. You can try this out quickly by using M-x rgrep and navigating the results with M-g n.

[vspinu]

Doesn’t next-error only work on a per-buffer basis? What I mean by this is that
the compilation error might be on a different buffer than the one I am compiling

No. next error works on the most recent compilation buffer. You need not
be in compilation buffer to use next-error. This, btw, works with
common compilation buffers like occur and grep. Very handy.

[hugoduncan]

Will next-error work if the compilation error is not in the top level file that was being compiled (e.g. in a require'd file)?

[vspinu]

I think currently it doesn't, but it's a broken implementation anyways.

next-error should apply to compilation buffer (aka stacktrace in cider case). Then it will apply to all links that are defined in the stacktrace.

[tbatchelli]

@Vitoshka If this is the case for next-error, then I am not sure it would work in the compilation case, as the broken clojure file doesn't appear in the stack trace, at least not that I could find.

[hugoduncan]

With the latest cider, compilation errors seem to highlight the wrong code.

[philc]

I see the same issue as @hugoduncan

[philc]

For those this affects, it's annoying because not only does the compilation error highlight the wrong code (in my case, something in my ns declaration when encountering a null pointer exception), but it auto-jumps there, taking the actual problematic code that I was just working on off-screen.

A workaround is to set cider-auto-jump-to-error to nil.