Supporting clojure.test/with-test

[giorgio-v]

Would it be possible to extend Cider to support the clojure.test/with-test macro?

Basically, I’d like to run tests defined in this way, too:

(test/with-test
  (defn hello [name]
    (str "Hello, " name))
  (is (= (hello "Brian") "Hello, Brian"))
  (is (= (hello nil) "Hello, ")))

Right now, these are not loaded because they are attached as meta data to the functions.

[jeffvalk]

It should be possible, yes. I will look into this, but possibly not for a little while.

This is way of writing tests was obviously a supported feature early in Clojure's history, but I don't think many people write tests this way in practice.

[giorgio-v]

I see.

Honestly, I’m trying to figure out if this style of testing is worth the pain, given the lack of tool support. I like the idea to define tests and functions in the same place, I think it gives you a much better context, but the supposed advantage could be offset if the friction with tools is too high.

[bbatsov]

Btw, @jeffvalk any plans to work on this?

[jeffvalk]

I hadn't thought about it...but now that I am, I'm not sure why this doesn't work as is. I'll look at it.

[bbatsov]

Great!

[Malabarba]

I'm not sure why this doesn't work as is. I'll look at it.

My guess would be that with-tests adds the tests to the function metadata, which is on the current namespace. However, CIDER only ever runs tests from one namespace. So if there's also a namespace called current.namespace-test, then CIDER is only going to run tests from the latter.

Just a guess, though. :-)

[jeffvalk]

@Malabarba Yep, seems likely. If that's the case, running tests with suppress-inference should pick these up. And if that's true, this issue is already resolved.

[bbatsov]

Maybe. :-) Although we might have to account for tests being in the same namespace and in a test namespace (which shouldn't be hard to do).

[bbatsov]

Did someone check this?

[jeffvalk]

@bbatsov Yes. @Malabarba is right. And the forthcoming (very soon!) commit to add #1226 will close this issue.

[derekchiang]

@jeffvalk sorry if I missed something obvious, but how is this issue fixed? As in, how exactly do I run the tests defined with with-test?

[bbatsov]

with-tests adds some metadata that CIDER uses to know if something is a test that needs to be run or not. You can just use its functionality to run the tests in the current namespace.