cider-repl-set-ns changes repl session from cljs:shadow to clj

[kakaLQY]

Expected behavior

cider-repl-set-ns should not change the cider-repl session type.

Actual behavior

cider-repl-set-ns in a cljs:shadow session will change the session type to clj.

Steps to reproduce the problem

In a shadow-cljs project, run cider-repl-set-ns. The cider-repl session will be changed from cljs:shadow to clj by checking with sesman-browser.

Environment & Version information

CIDER version information

;; CIDER 1.5.0-snapshot (package: 1.5.0-snapshot), nREPL 0.9.0
;; Clojure 1.10.3, Java 11.0.15

Lein / Clojure CLI version

1.11.1

Emacs version

28.1

Operating system

NixOS

JDK distribution

openjdk version "11.0.15" 2022-04-19

Hints

It seems the bug is introduced by 5f705b0, as after reverted, the bug will be gone.

[caumond]

+1, on CIDER 1.5.0-snapshot, clj 1.10.0, emacs 28.1, ubuntu, jdk 11.0.16+8-post-Ubuntu-0ubuntu122.04

[jellelicht]

This behaviour seems to somehow be triggered through the cider-repl--state-handler function, and specifically the following snippet:

(when (and repl-type cider-repl-auto-detect-type)
    (cider-set-repl-type repl-type))

For whatever reason, the response object seems to indicate a repl-type of clj in my shadow-cljs repl.

[jellelicht]

Using cider-tooling-eval passes along 'tooling to nrepl-request:eval. I'm guessing this leads to using the 'wrong' session somehow, one where the repl-type is (still) clj instead of cljs.

[bbatsov]

That's an interesting edge case as there's just a single tooling session and it's a Clojure session. Perhaps for ClojureScript we can run this in the ClojureScript eval session instead, although it's going to mess a bit with the eval results vars (e.g. *1).

[jellelicht]

@bbatsov Perhaps a stupid idea, but maybe we can temporarily re-bind cider-repl-auto-detect-type to be falsey?

[tvirolai]

I got bitten by this as well when running a cljs REPL using figwheel-main. Whenever I switch to a namespace using cider-repl-set-ns, the cider-repl-type is changed to clj. When I type in code in the REPL, it gets evaluate just fine - but the REPL jumps back to user.cljs as the parameter gets switched back to cljs after the evaluation. Specs: CIDER 1.5.0, Clojure 1.10.2, Java 17.0.1, Emacs 28.2, Mac OS Ventura 13.0.

[AndreaCrotti]

I'm having the same issue with cider 1.6.0-SNAPSHOT actually, would be nice to have a workaround at least

[scott-kl]

The workaround I have is to navigate to the shadow repl manually, enter the namespace of the file, navigate back to the file and eval/load it with ctrl-k. I've been meaning to put this into an elisp fn. If I do I'll post it here.

[AndreaCrotti]

Another way I found is to just do a cider-set-repl-type on the shadow cljs repl after I messed it up, not great though I wonder why it even thinks it's a clj repl in the first place.

[bbatsov]

@yuhan0 Can you take a look at this?

[scott-kl]

This is the hack I came up with if anybody wants a quick fix.

(defun switch-to-shadow ()
  (interactive)
  (cider-switch-to-repl-buffer t)
  (sit-for 0.5) ;; above call doesn't come back in time to reset the repl??
  (cider-set-repl-type "cljs"))