cider-current-ns can get confused by namespace metadata with newline

[vemv]

Given this Clojure ns declaration:

(ns ^{:doc "An awesome namespace"}
    my-ns
   ...)

When one places the cursor exactly in the my-ns line, (cider-current-ns) will return "^{:doc".

Both conditions must happen: newline after metadata, and cursor being in the my-ns line.

It works well in all other cases.

I'm using CIDER latest. This looks environment-independent and easy to reproduce, so kindly allow me to skip the issue template.

Cheers - Victor

[bbatsov]

And this is most likely an issue with clojure-mode, not CIDER. 😉

[bbatsov]

On a related note:

(ns ^{:doc "An awesome namespace"}
    my-ns
   ...)

Would normally be written as:

(ns my-ns
   "An awesome namespace"
   ...)

[bbatsov]

Yeah, I can now confirm that this is a bug in clojure-find-ns.

[xiongtx]

Actually, this can occur any time when point is in the middle of what is considered an "ns form" by the clojure-namespace-name-regex regexp. E.g. w/ | as point:

(ns ^{:doc |"An awesome namespace"}
    my-ns
   ...)

or

(ns ^{:doc "An awesome namespace"} |my-ns
   ...)

A simple solution would be to always move to top level, so we don't do the re-search-backward in clojure-find-ns from the middle of the match.

[vemv]

And this is most likely an issue with clojure-mode, not CIDER. 😉

Whoops! Sorry.

Would normally be written as [...]

Sure 👍 it was a minimal example.

Thanks both for the fix!