Skip to content

When disabling a theme, faces are not updated accordingly. #1987

@ustun

Description

@ustun

Previously, we were only updating faces when we enable themes.

We need to update the faces whenever a theme is disabled, otherwise after disabling a dark theme like molokai, the background colors are still black in the default emacs theme.

Expected behavior

When disabling a theme, backgroud colors of error reports etc should be re-calculated.

Actual behavior

Previous theme's colors are taken into account when disabling a theme.

Steps to reproduce the problem

Enable a theme on emacs startup. (possibly a dark one)
Start cider.
Disable theme.
Run a failing test.
The background color for tests still are like that of the disabled theme.

Before

image

After

image

Environment & Version information

CIDER version information

;; CIDER 0.15.0snapshot (package: 20170506.1322), nREPL 0.2.12
;; Clojure 1.8.0, Java 1.8.0_45

Lein/Boot version

Leiningen 2.7.1 on Java 1.8.0_45 Java HotSpot(TM) 64-Bit Server VM

Emacs version

GNU Emacs 25.2.1 (x86_64-apple-darwin16.5.0, Carbon Version 157 AppKit 1504.82) of 2017-04-28

Operating system

macOS

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions