Eval'ing (keyword "\"|") gives "Search failed" error

[brianfay]

Expected behavior

When evaluating (keyword "\"|"), the keyword :"| should be displayed in the minibuffer.

Actual behavior

When evaluating (keyword "\"|"), the minibuffer displays a regex error:

error in process filter: Search failed: "\\(\\s-\\|^\\|#\\|(\\|\\[\\|{\\)\\(\"\\)"

Steps to reproduce the problem

Evaluate

(keyword "\"|")

using cider-eval-last-sexp or a similar command.

Alternatively, evaluate

(def k (keyword "\"|"))

and try evaluating k.

Environment & Version information

Using the clojure configuration layer in spacemacs

CIDER version information

;; CIDER 0.15.0snapshot (package: 20170322.155), nREPL 0.2.12
;; Clojure 1.8.0, Java 1.8.0_101

Lein/Boot version

Lein 2.6.1

Emacs version

Gnu Emacs 24.5.1

Operating system

OS X Sierra

Other notes

xiongtx on Slack brought up a good point that " and | are technically not considered valid characters for clojure keywords and symbols, even though they generally work in practice.

[dpsutton]

This appears to be a bug in clojure-font-lock-keywords from clojure-mode.

Here's a stacktrace:

clojure-string-start(t)
  clojure--font-locked-as-string-p(regexp)
  clojure-font-lock-regexp-groups(4)
  font-lock-fontify-keywords-region(1 4 nil)
  font-lock-default-fontify-region(1 4 nil)
  apply(font-lock-default-fontify-region 1 4 nil)
  (closure ((func . font-lock-default-fontify-region) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest))(1 4 nil)
  apply((closure ((func . font-lock-default-fontify-region) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) 1 4 nil)
  (closure ((func closure ((func . font-lock-default-fontify-region) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest))(1 4 nil)
  apply((closure ((func closure ((func . font-lock-default-fontify-region) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) 1 4 nil)
  (closure ((func closure ((func closure ((func . font-lock-default-fontify-region) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn ... ... ...) (if modified nil ...))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest))(1 4 nil)
  apply((closure ((func closure ((func closure ((func . font-lock-default-fontify-region) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn ... ... ...) (if modified nil ...))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) 1 4 nil)
  (closure ((func closure ((func closure ((func closure (... cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ... ...) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn ... ... ...) (if modified nil ...))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest))(1 4 nil)
  apply((closure ((func closure ((func closure ((func closure (... cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ... ...) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn ... ... ...) (if modified nil ...))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) 1 4 nil)
  (closure ((func closure ((func closure ((func closure (... cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ... ...) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified ...) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn ... ... ...) (if modified nil ...))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote ...)) (add-text-properties beg end (quote ...)) (if cider-font-lock-dynamically (progn ...))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest)) cider--debug-mode cider--debug-mode-response t) (beg end &rest rest) (let* ((modified (buffer-modified-p)) (buffer-undo-list t) (inhibit-read-only t) (inhibit-modification-hooks t)) (unwind-protect (progn (remove-text-properties beg end (quote (cider-locals nil cider-block-dynamic-font-lock nil))) (add-text-properties beg end (quote (help-echo cider--help-echo))) (if cider-font-lock-dynamically (progn (cider--update-locals-for-region beg end)))) (if modified nil (restore-buffer-modified-p nil)))) (apply func beg end rest))(1 4 nil)
  font-lock-fontify-region(1 4)
  cider-font-lock-as(clojure-mode ":\"|")
  cider-font-lock-as-clojure(":\"|")
  cider-repl-emit-result(#<buffer *cider-repl fizzbuzz*> ":\"|" t)

[expez]

Garbage in, garbage out. I think we should close this, not complicate the code with this strange edge-case, and direct work toward useful features.

[bbatsov]

@expez I agree to some extent, but I think we should at least handle this error, so it doesn't propagate to the users. I think in the case of garbage in we should apply no font-locking. That'd be simple and better UX imo.

[bbatsov]

Probably adding handling for those chars would not be complex either, but I don't have time to look into this.

[xiongtx]

While the reader allows it, the spec does not include " as a legal constituent of a symbol or keyword:

Symbols begin with a non-numeric character and can contain alphanumeric characters and *, +, !, -, _, ', and ? (other characters may be allowed eventually)

Keywords are like symbols

But then again, a number of libraries grossly violate the ban against . in keywords:

They cannot contain '.' or name classes.

[WhittlesJr]

Maybe this should be a separate issue, but I get the same error when evaluating the following:

(apply str (map char (range 33 41)))

Ran into this because I needed to generate ASCII characters sequentially. I reduced it down to this particular range in this particular order, which is:

!\"#$%&'(

If you start higher than 33 or end lower than 41(40), it will print just fine.

Runs fine on repl.it, and also works fine if you just reverse the sequence.

It will also choke if you just try to evaluate the string itself:

"!\"#$%&'("

And I found that you can strip out all characters except the following to reproduce it:

!\"(

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[stale]

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

[pdenno]

I get this often when printing a large map or vector to the REPL.
What *Messages* says is:
clojure-string-start: Search failed: "\\(\\s-\\|^\\|#\\|(\\|\\[\\|{\\)\\(\"\\)"
error in process filter: Search failed: "\\(\\s-\\|^\\|#\\|(\\|\\[\\|{\\)\\(\"\\)"

I updated today to clojure-mode-20191112.1948 but it doesn't help. clojure-string-start hasn't changed since at least 20180202.

You should be able to reproduce it with the attached file:
(read-string (slurp "bad.txt))
bad.txt