CIDER creates a bunch of *nrepl-messages [...]* buffers

[expez]

Latest CIDER:

[expez]

Most of these seem to contain only:

(<- 
  id  "13"
  out  "To quit, type: :cljs/quit\n"
  session  "22726a7d-0815-44a8-b716-5275b9e3419f"
)

With varying session and id.

[expez]

New buffers are created when I run the refactor-nrepl resolve_missing tests in emacs.

The boilerplate was copied wholesale from cider-nrepl so the same likely happens when those tests are run in emacs.

I'm not sure if this is expected or not, but at least this means this bug probably doesn't affect 'real' users.

[bbatsov]

Hmm, I wonder what's causing the creation of new sessions... At any rate - it would have been better if we aggregated the messages per connection instead of per session, but the logging code is an place where the connection is not directly available and fetching it by session requires some coupling to cider, which I wanted to avoid.

[cddr]

I get this as well just from normal usage.

[bbatsov]

I plan to fix this, but it requires a bunch of changes to the nrepl-client.el, which I don't have time to do right now - mainly passing the connection all the way down to the logging code.

[Malabarba]

@bbatsov What if we just keep the old behaviour (single buffer) by default, and have a custom var to get the new behavior (per-session buffers)? I'm happy with the "per-session" buffers, and I don't particularly feel the need to make them "per-connection".

Plus, this would take like 3 min to code. :)

[bbatsov]

Nope. There has to be some incentive to fix the fucked-up logging in a proper manner... Sessions logs were a bad idea (mostly because of the throwaway sessions we didn't anticipate), that's clear now - but we did it because it was an easier solution. I'm add fine with adding an option to merge the log into one buffer, but only when I get to aggregate all connection sessions together.

[Malabarba]

Alright then. :-)

[bbatsov]

I get your point, but I'm way too wary of quick fixes, that become permanent. I'll try to find some time for this by the end of the week.