Skip to content

Erroneous underlining in error buffer #1033

@cichli

Description

@cichli
  • The filter buttons are always underlined, even when toggled off
  • All frames are underlined

e.g. with font-lock-mode enabled/disabled:

screenshot 2015-03-20 12 28 01
screenshot 2015-03-20 12 29 03

It seems the default button face is always being used as button only cares about the face property and not the font-lock-face property. If I change cider-stacktrace.el to use face when rendering the buttons and frames, all is better with both font-lock-mode enabled and disabled:

screenshot 2015-03-20 12 36 54
screenshot 2015-03-20 12 37 06

Would you accept a PR to this effect? The change to font-lock-face was in 401e819, to fix #749 - but I think in this particular case, things like parenface and rainbow-delimiters don't really apply. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions