Refine =-body behavior
#739
Conversation
|
Why did you change the PR template? |
|
It seemed cluttered, when I receive an email with someone else's PR, reading the instructions yet again seems tiring. (Also |
The purpose for this is not to have to explain the instructions again and again to new contributors, that's why I want this as detailed as possible. Please, remove those changes from the commit. I'd also separate the lint changes to a different commit as well. |
|
The changes to the test middleware look good. |
I think contributors can observe the comments - at least that has been my experience maintaining issue templates. Perhaps we can add a particularly unmistakable prelude? |
|
My observation is that almost no one reads stuff, that's why I like the explicit template. And I think that's the observation of many people, otherwise GitHub would not have added this feature. ;-) |
|
Oh IDK, the template is pretty flexible as to what it can contain. One also can observe that the template often is entirely skipped, even when it had room to be followed (especially for test coverage). My line of thinking is that by making it more concise, hopefully people will pay a little more attention to it, else it might look like boilerplate after the nth PR. Ultimatately I can concede oc, but maybe it's good food for thought? |
|
The template is mostly for new/infrequent contributors. Seasoned contributors don't really need it, as they obviously know what's expected.
Okay, we can revisit the subject down the road. At any rate - I don't like discussing unrelated things in the same PR. Single focus, quick turnaround. |
* Unwrap lists for :actual for `=` arity 2 * Use traditional clojure.test notation for `=` arity 3+ Fixes #735
|
thanks @vemv |
3 participants
:actualin=arity 2:actualin=arity 3+This is clearly reflected in the included tests.
Fixes #735