Remove workaround for converting column numbers #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 7, 2020
bbatsov
reviewed
Jun 7, 2020
src/cider/nrepl/middleware/debug.clj
Outdated
| ;; Passing clojure.lang.Namespace object | ||
| ;; as :original-ns breaks nREPL in bewildering | ||
| ;; ways. | ||
| ;; NOTE: column numbers in the response map |
There was a problem hiding this comment.
Probably we should also mention this in the debugger docs.
There was a problem hiding this comment.
Do you mean the docs in this repo or Cider's?
There was a problem hiding this comment.
CIDER's. I think we don't have any debugger documentation elsewhere, although we should change this at some point.
yuhan0
force-pushed
the
fix-debug-column-num
branch
from
251d7cc to
b18d199
Compare
|
All of the builds are failing now. It seems one test needs to be updated. |
bbatsov
reviewed
Jun 7, 2020
CHANGELOG.md
Outdated
| ### Bugs fixed | ||
|
|
||
| * Bump Orchard to 0.5.10, as the 0.5.9 was a bad build. ([Orchard issue](https://github.com/clojure-emacs/orchard/issues/91)) | ||
| * Remove workaround for converting column numbers to 0-based indexing. ([Cider issue](https://github.com/clojure-emacs/cider/issues/2852)) |
There was a problem hiding this comment.
I think you forgot to delete this.
yuhan0
force-pushed
the
fix-debug-column-num
branch
from
b18d199 to
b8cb097
Compare
|
Whoops, I removed the duplicated line, still investigating the test failures (can't get them to run locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes clojure-emacs/cider#2852