There is a lot of reflection warnings

[vigneshsarma]

I have fixed the easy ones. There is some more left.

the remaining ones,

Reflection warning, cider/nrepl/middleware/out.clj:53:22 - call to method write can't be resolved (target class is unknown).
Reflection warning, cider/nrepl/middleware/out.clj:55:24 - call to method write on java.lang.Object can't be resolved (no such method).
Reflection warning, cider/nrepl/middleware/out.clj:55:24 - call to method write on java.lang.Object can't be resolved (no such method).
Reflection warning, cider/nrepl/middleware/out.clj:57:22 - call to method write can't be resolved (target class is unknown).
Reflection warning, cider/nrepl/middleware/out.clj:59:24 - call to method write on java.lang.Object can't be resolved (no such method).
Boxed math warning, byte_streams/graph.clj:130:77 - call: public static double clojure.lang.Numbers.unchecked_add(java.lang.Object,double).
Reflection warning, cider/nrepl/middleware/out.clj:59:24 - call to method write on java.lang.Object can't be resolved (no such method).
Reflection warning, cider/nrepl/middleware/out.clj:61:21 - reference to field flush can't be resolved.
Reflection warning, cider/nrepl/middleware/out.clj:63:23 - reference to field flush on java.lang.Object can't be resolved.
Reflection warning, cider/nrepl/middleware/out.clj:63:23 - reference to field flush on java.lang.Object can't be resolved.

Reflection warning, cider/nrepl/middleware/inspect.clj:47:25 - call to java.lang.Exception ctor can't be resolved.

Reflection warning, cider/nrepl/middleware/debug.clj:159:29 - reference to field sym on java.lang.Object can't be resolved.
Reflection warning, cider/nrepl/middleware/debug.clj:159:29 - reference to field sym on java.lang.Object can't be resolved.

Not completly sure how to fix the remaining ones.

[cichli]

Thanks for the contribution! Could you change the commit message to be in the imperative? i.e. Fix reflection warnings.

[cichli]

Could you fix the indentation here?

[vigneshsarma]

Updated.

[cichli]

I have pushed a commit that will fix the Eastwood warnings, if you would like to rebase.

[vigneshsarma]

I have rebased it with master and also fixed the commit message.

I am not sure how to fix the remaining reflection warning. If you have ideas, I can fix them as well.

[codecov]

Codecov Report

Merging #589 into master will increase coverage by 0.04%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   76.68%   76.72%   +0.04%     
==========================================
  Files          38       38              
  Lines        2393     2389       -4     
  Branches      140      138       -2     
==========================================
- Hits         1835     1833       -2     
  Misses        418      418              
+ Partials      140      138       -2

Impacted Files	Coverage Δ
src/cider/nrepl/middleware/content_type.clj	33.33% <0%> (ø)	⬆️
src/cider/nrepl/print_method.clj	76.92% <100%> (ø)	⬆️
src/cider/nrepl/middleware/slurp.clj	61.11% <25%> (+0.58%)	⬆️
src/cider/nrepl/middleware/debug.clj	55.21% <66.66%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8843848...72adfd4. Read the comment docs.

[cichli]

Fixed in d5f1f3a. Thanks so much for looking at this – sorry it's taken me a while to get it merged.

I am not sure how to fix the remaining reflection warning. If you have ideas, I can fix them as well.

If I get around to taking a look at them I'll ping you.