Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Dec 10, 2025

Description

Backports #7390 to main

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization

    • Updated Polish translations for organization creation, switching, and management features with proper localized strings replacing placeholders.
    • Enhanced Polish language support for password reset, authentication workflows, and sign-out actions.
    • Added comprehensive Polish translations for organizational task selection flows, form controls, and API management screens.
  • Chores

    • Added changeset file.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

🦋 Changeset detected

Latest commit: 629ee14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Dec 10, 2025 6:05pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

This PR adds a changeset entry and populates previously undefined Polish localization strings across multiple UI components with actual translated text, maintaining all existing type structures.

Changes

Cohort / File(s) Summary
Changeset metadata
.changeset/tender-hairs-smash.md
Empty changeset file with document separators only; no functional configuration.
Polish localization updates
packages/localizations/src/pl-PL.ts
Replaces undefined or placeholder translation values with concrete Polish strings for organization management, task flows, and authentication components (e.g., "Utwórz organizację", "Zamknij", "Zresetuj hasło"). No API or type structure changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

  • Straightforward localization string updates with no logic or structural changes
  • Changeset file is metadata-only
  • Primary effort: spot-check Polish translations for accuracy and consistency

Poem

🐰 Polish words now spring to life,
No more undefined in the strife!
"Utwórz" and "Zamknij" find their place,
With hopping joy, we've set the pace! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: backporting Polish localizations. It directly matches the changeset's primary focus of updating Polish translations in the localization file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/backport-7390

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8da0107 and 629ee14.

📒 Files selected for processing (2)
  • .changeset/tender-hairs-smash.md (1 hunks)
  • packages/localizations/src/pl-PL.ts (3 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/pl-PL.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/pl-PL.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/pl-PL.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/pl-PL.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/pl-PL.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/pl-PL.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)
  • GitHub Check: Unit Tests (shared, clerk-js, RQ)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Static analysis
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
.changeset/tender-hairs-smash.md (1)

1-2: Verify the empty changeset file is intentional.

This changeset file contains only YAML separators without any package specifications, version bump types, or change descriptions. While empty changesets are technically valid, they typically include at least a summary of the changes.

Please confirm whether this is intentional or if the changeset should include package and version information for the localization updates.

packages/localizations/src/pl-PL.ts (5)

267-273: LGTM! Organization list translations added.

The Polish translations for the organization list section are now properly populated. The use of template variables like {{applicationName}} is correct, and the translations for related keys like action__createOrganization and createOrganization are consistent.


279-279: LGTM! API keys page title translated.

The Polish translation for the API keys page title has been properly added.


498-503: LGTM! Organization switcher actions translated.

The Polish translations for organization switcher actions are now properly populated. The translation for action__suggestionsAccept is consistent with the same action in the organizationList section.


851-873: LGTM! Task choose organization section fully translated.

All previously undefined Polish translations in the taskChooseOrganization section have been properly populated, including:

  • Organization selection actions and labels
  • Organization creation form fields and buttons
  • Sign-out action text

Template variables are used correctly throughout.


876-881: LGTM! Task reset password translations added.

The Polish translations for the password reset task have been properly added, including the form button, sign-out actions, and title. Template variable usage for {{identifier}} is correct.

Note: Line 882 subtitle remains undefined, which appears to be intentional as it wasn't changed in this PR.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7429

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7429

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7429

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7429

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7429

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7429

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7429

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7429

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7429

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7429

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7429

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7429

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7429

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7429

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7429

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7429

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7429

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7429

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7429

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7429

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7429

commit: 629ee14

@wobsoriano wobsoriano merged commit 4b9871c into main Dec 10, 2025
71 of 72 checks passed
@wobsoriano wobsoriano deleted the rob/backport-7390 branch December 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants