fix(nextjs): Execute logger.commit() on every middleware invocation #3871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using the `withLogger` wrapper to handle the logger.commit on every time the wrapped function is executed. In `clerkMiddleware` we are wrapping the whole function with the `withLogger` instead of the returned nextMiddleware that is executed in every request causing the `logger.commit()` to be executed once during the initialization of the `clerkMiddleware()` (on 1st request). To make debug logs working for `clerkMiddleware` on every request we need to move the `withLogger` to wrap the returned middleware instead. In `authMiddleware` we are wrapping the returned nextMiddleware which makes the debugging logs works without any change.
🦋 Changeset detectedLatest commit: 73a3cf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
fix/nextjs-debug-logger
branch
from
63eab8e to
50e36a9
Compare
nikosdouvlis
approved these changes
Aug 1, 2024
wobsoriano
pushed a commit
that referenced
this pull request
Aug 1, 2024
…3871) Co-authored-by: Nikos Douvlis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are using the
withLoggerwrapper to handle the logger.commit on every time the wrapped function is executed.In
clerkMiddlewarewe are wrapping the whole function with thewithLoggerinstead of the returned nextMiddleware that is executed in every request causing thelogger.commit()to be executed once during the initialization of theclerkMiddleware()(on 1st request). To make debug logs working forclerkMiddlewareon every request we need to move thewithLoggerto wrap the returned middleware instead.In
authMiddlewarewe are wrapping the returned nextMiddleware which makes the debugging logs works without any change.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change