fix(elements): Display assertIsDefined errors during development
#3517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b446576 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
changed the title
assertIsDefined errors during development
LekoArts
commented
Jun 5, 2024
| if (process.env.NODE_ENV === 'development') { | ||
| assertActorEventError(event); | ||
|
|
||
| throw new ClerkElementsRuntimeError(`Unable to fulfill the prepare or attempt request for the sign-in verification. |
Contributor
Author
There was a problem hiding this comment.
We can say prepare/attempt here because the action is only used in those two states
LekoArts
commented
Jun 5, 2024
| } | ||
|
|
||
| assertIsDefined(params); | ||
| assertIsDefined(params, 'First factor params'); |
Contributor
Author
There was a problem hiding this comment.
I've added a label to all instances of assertIsDefined. If params would be undefined it would say:
undefined is not defined
With the label it'll say
First factor params is not defined
👍
anagstef
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So inside our sign-in verification machine we use
assertIsDefineda bunch. Those errors weren't displayed anywhere, you could only see them if you've usedNEXT_PUBLIC_CLERK_ELEMENTS_DEBUG=true.In SDK-1470 I recorded how I got into such a state some time ago. Actually, I wasn't able to reproduce now because our conditional logic is better now. However, if for some reason a user gets into the state of
assertIsDefinedthrowing, they'll now see it at least 👍Fixes SDK-1470
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change