Skip to content

Conversation

@panteliselef
Copy link
Contributor

@panteliselef panteliselef commented May 29, 2024

Description

We are temporarily pinning the node versionto unblock CICD, will revert the change soon

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 0eed788

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef changed the title ci(*): Pin node version to unblock ci/cd ci(*): Pinned node version May 29, 2024
@panteliselef panteliselef changed the title ci(*): Pinned node version ci(*): Pinned node version May 29, 2024
@panteliselef panteliselef enabled auto-merge (squash) May 29, 2024 20:24
description: 'The node version to use'
required: false
default: '18'
default: '18.20.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default: '18.20.2'
# This is pinned to `18.20.2` because `18.20.3` bumps npm from `10.5.0` to `10.7.0`, which causes our verdaccio setup to fail.
default: '18.20.2'

@panteliselef panteliselef merged commit ce82fdc into main May 29, 2024
@panteliselef panteliselef deleted the elef/fix-ci-node-version branch May 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants