Support capital 'Darwin' $OSTYPE #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some macOS environments, the `$OSTYPE` environment variable is 'Darwin' (capitalized) and not 'darwin'. This caused the install script to echo "OS Darwin is not supported!" and exit, even if everything was in fact in order. This patch uses a case-insensitive regex against a [standard bash operator](1) to allow any `$OSTYPE` that starts with 'Darwin' or 'darwin'. All other instances of conditional checks for darwin* are also patched across the code base. [1]: https://www.gnu.org/software/bash/manual/bash.html#index-_005d_005d
|
Also - so happy I found this. Multiple times per day at work I press escape in out ticketing system's textarea and loose my entire comment. Really cool that you pulled this off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some macOS environments, the
$OSTYPEenvironment variable is'Darwin' (capitalized) and not 'darwin'. This caused the install script
to echo "OS Darwin is not supported!" and exit, even if everything was
in fact in order.
This patch uses a case-insensitive regex against a standard bash
operator to allow any
$OSTYPEthat starts with 'Darwin' or'darwin'.
All other instances of conditional checks for darwin* are also patched
across the code base.