Security: mktemp, file permissions, removing temp file after. And a basic feature I needed. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrzasa
changed the title
davidfetter
reviewed
Jan 13, 2019
| # Linux | ||
| if [[ $OSTYPE == "linux-gnu" ]]; then | ||
| chmod o-r $TMPFILE # Make file only readable by you | ||
| chmod 600 $TMPFILE # Make file only readable by you |
There was a problem hiding this comment.
Should this be one of chmod 0600 or chmod go-rwx?
There was a problem hiding this comment.
I don't understand your question.
There was a problem hiding this comment.
Your original command removed permission only from other. My suggestion was to ensure that only your user be allowed, i.e. to remove permission from others in the group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think you should seriously consider using
mktempas in the first commit. Not tested on OSX!Starting vim with current clipboard already in the editor seemed quite natural for me, but it's just my concept of using vim-anywhere.