feat(scripting/v8): add better api for doing raw events #3782
+592
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds global definitions for functions that previously didn't have any: - printError - RegisterNetEvent - Citizen.invokeNativeByHash - msgpack_pack - msgpack_unpack This removes an old global declaration for a function that doesn't exist - Citizen.invokeFunctionReference Adjusts `SendNUIMessage` to only take `object` types, since it requires an object type for JSON. This adds a bunch of documentation to all of the global functions to try and describe what they do
This unifys some internal logic for how emitters are registered so they behave the same for raw/regular emitters, making it so you don't have to do a bunch of internal calls that most people wouldn't know about
github-actions
bot
added
the
triage
AvarianKnight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Get feature parity for raw emitters and regular emitters
This makes it a lot easier to work with protobufs where the situation arises where we
need a more efficient packing format.
How is this PR achieving the goal
Adds
onRawNet,emitRawNet,emitRawandremoveRawEventListenerThis PR applies to the following area(s)
JS
Successfully tested on
Game builds: ..
Platforms: Windows, Linux
Checklist