BLE Disconnect on File Write Operations

[makermelissa]

CircuitPython Version

10.0.0-beta.3

Workflow(s)

BLE

Browser(s)

Chrome (latest)

Console Log

[Violation] 'click' handler took 1097ms
index.js:21 Uncaught (in promise) Error: Modal has not been opened yet. No instance available
    at gi.getModal (index.js:21:14076)
    at DR._markStepCompleted (index.js:112:6919)
    at DR.connectionStep (index.js:112:6850)
    at DR.updateConnected (index.js:112:24682)
    at DR.onDisconnected (index.js:112:3749)
getModal @ index.js:21
_markStepCompleted @ index.js:112
connectionStep @ index.js:112
updateConnected @ index.js:112
onDisconnected @ index.js:112Understand this error
[Violation] 'click' handler took 4949ms
index.js:40 caught connection error NetworkError: Failed to execute 'getPrimaryService' on 'BluetoothRemoteGATTServer': GATT Server is disconnected. Cannot retrieve services. (Re)connect first with `device.gatt.connect`.
    at IE.checkConnection (index.js:40:4356)
    at IE.move (index.js:40:11590)
    at Ou._handleRenameButton (index.js:32:103194) NetworkError: Failed to execute 'getPrimaryService' on 'BluetoothRemoteGATTServer': GATT Server is disconnected. Cannot retrieve services. (Re)connect first with `device.gatt.connect`.
    at IE.checkConnection (https://code-beta.circuitpython.org/assets/js/index.js:40:4356)
    at IE.move (https://code-beta.circuitpython.org/assets/js/index.js:40:11590)
    at Ou._handleRenameButton (https://code-beta.circuitpython.org/assets/js/index.js:32:103194)
index.js:40 caught write error TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (index.js:40:4911)
    at IE.move (index.js:40:11812)
    at async DR.showBusy (index.js:112:4411)
    at async Ou._handleRenameButton (index.js:32:103156) TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (https://code-beta.circuitpython.org/assets/js/index.js:40:4911)
    at IE.move (https://code-beta.circuitpython.org/assets/js/index.js:40:11812)
    at async DR.showBusy (https://code-beta.circuitpython.org/assets/js/index.js:112:4411)
    at async Ou._handleRenameButton (https://code-beta.circuitpython.org/assets/js/index.js:32:103156)
index.js:40 caught write error TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (index.js:40:4911)
    at IE.move (index.js:40:11833)
    at async DR.showBusy (index.js:112:4411)
    at async Ou._handleRenameButton (index.js:32:103156) TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (https://code-beta.circuitpython.org/assets/js/index.js:40:4911)
    at IE.move (https://code-beta.circuitpython.org/assets/js/index.js:40:11833)
    at async DR.showBusy (https://code-beta.circuitpython.org/assets/js/index.js:112:4411)
    at async Ou._handleRenameButton (https://code-beta.circuitpython.org/assets/js/index.js:32:103156)
index.js:40 caught write error TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (index.js:40:4911)
    at IE.move (index.js:40:11854)
    at async DR.showBusy (index.js:112:4411)
    at async Ou._handleRenameButton (index.js:32:103156) TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (https://code-beta.circuitpython.org/assets/js/index.js:40:4911)
    at IE.move (https://code-beta.circuitpython.org/assets/js/index.js:40:11854)
    at async DR.showBusy (https://code-beta.circuitpython.org/assets/js/index.js:112:4411)
    at async Ou._handleRenameButton (https://code-beta.circuitpython.org/assets/js/index.js:32:103156)
index.js:40 caught write error TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (index.js:40:4911)
    at IE.move (index.js:40:11903)
    at async DR.showBusy (index.js:112:4411)
    at async Ou._handleRenameButton (index.js:32:103156) TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse')
    at IE._write (https://code-beta.circuitpython.org/assets/js/index.js:40:4911)
    at IE.move (https://code-beta.circuitpython.org/assets/js/index.js:40:11903)
    at async DR.showBusy (https://code-beta.circuitpython.org/assets/js/index.js:112:4411)
    at async Ou._handleRenameButton (https://code-beta.circuitpython.org/assets/js/index.js:32:103156)

Steps

1. Make sure a CIRCUITPY drive is NOT showing
2. Connect to the board
3. Click Save As
4. Rename an existing file
5. Errors in console

Description

I'm seeing at least 3 different kinds of errors and I'm not sure how interrelated they are:

-There are click handler violations to begin with. This is caused by a click event showing the modal and not returning control in a reasonable amount of time. Not sure how to work around this.

• Getting Failed to execute 'getPrimaryService' on 'BluetoothRemoteGATTServer': GATT Server is disconnected. Cannot retrieve services. and not sure why since it seems to be connected just fine. Perhaps an issue with the simplified BLE Workflow.
• Getting caught write error TypeError: Cannot read properties of null (reading 'writeValueWithoutResponse') and I'm not sure what that means

Additional information

No response

[makermelissa]

This may be related to #372

[makermelissa]

It appears to disconnect right after a rename for some reason.

[makermelissa]

Ok, I think I figured it out. It looks like the BLEWorkflow.onAdvertisementReceived function is getting called when file operations happen. I think we just need to stop listening after connecting.

[makermelissa]

The auto reconnect also was trying to call clearConnectStatus which was referring to the connect dialog, which wasn't shown.

[makermelissa]

Ok, I noticed something strange. Perhaps it is just my setup (which is perfect since I'm fixing it), but it connects 3 times and then gives caught connection error NetworkError: GATT operation already in progress errors. S I think it is establishing 3 connections that are stepping on each others' toes.

Edit:
Oops, that's why we have the abortController.abort() line. I had it commented out.

[makermelissa]

It seems to be most write operations cause this issue (moving and uploading aren't working at all for me locally). Reading files and listing folders work fine. I should also note I tried this with CP 9.2.9, which has the same behavior, so likely not CP related.

[makermelissa]

I noticed when I commented out the disconnect code, it adafruit-ble-file-transfer returns Invalid Path, which is a response to STATUS_ERROR.

[makermelissa]

After looking further, I believe this is a CircuitPython issue. I tried an older version (9.1.0) and it behaves as expected.

[makermelissa]

So the disconnection may not be related to CP after all.

Ok, Here's what I've gathered (assuming not mounted read only):
CP Version 9.1.0 Works, but disconnects
CP Version 9.2.9 Does not work and tries to disconnect
CP Version 10.0.0-RC0 same as 9.1.0

Also, if the USB drive is mounted, it does not give a readonly error. Just a regular error.

[makermelissa]

Ok, putting this on hold for now until I have any new ideas. I tried out the code from before I improved the connections and it did the same thing.