Skip to content

Fix TOC scroll cut off #9575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2025
Merged

Fix TOC scroll cut off #9575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
917a411
make more room for the toc to scroll
rosieyohannan Sep 8, 2025
ae9e093
correct toc-top
rosieyohannan Sep 8, 2025
768195e
use toc-top in toc.css
rosieyohannan Sep 8, 2025
f57712e
Merge branch 'main' into DOCSS-1895-see-full-page-toc
rosieyohannan Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/css/toc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
margin-top: -2.1rem;
margin-right: 0.75rem;
position: sticky;
top: calc(var(--spacing) * 35);
top: var(--toc-top);
}

.toc .toc-menu h3 {
Expand Down
4 changes: 2 additions & 2 deletions ui/src/css/vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@
--nav-panel-menu-height: calc(100% - var(--drawer-height));
--nav-panel-explore-height: calc(50% + var(--drawer-height));
--nav-width: calc(270 / var(--rem-base) * 1rem);
--toc-top: calc(var(--body-top) + var(--toolbar-height));
--toc-height: calc(100vh - var(--toc-top) - 2.5rem);
--toc-top: calc(var(--spacing) * 35); /* Empirically determined position: navbar + toolbar + additional spacing (≈8.75rem vs logical 6rem) */
--toc-height: calc(100vh - var(--toc-top) - 6.2rem);
--toc-width: calc(265 / var(--rem-base) * 1rem);
--toc-width--widescreen: calc(474 / var(--rem-base) * 1rem);
--doc-max-width: calc(720 / var(--rem-base) * 1rem);
Expand Down