Show bridges active in room in settings #713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginnyTheCat
force-pushed
the
bridge
branch
3 times, most recently
from
c7daef9 to
5edfa4d
Compare
ajbura
reviewed
Aug 14, 2022
There was a problem hiding this comment.
Looks like a nice addition but having a dedicated tab for it doesn't sounds like a good idea. Most of the rooms doesn't have integration and it wont serve any purpose.
Maybe we can have a About tab at the end which can show info like, roomId, who & when room is created, and integrations?
|
I thought that the integrations tab could later be extended with adding bridges and showing/adding bots. |
ginnyTheCat
force-pushed
the
bridge
branch
3 times, most recently
from
bb38fc2 to
32482cc
Compare
|
Closing as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shows the in room active bridges in the room settings in a new "Integrations" tab.
Clicking on the entry opens the platforms chat in a new tab (the Gitter bridge does this for example) or the services website (for example WhatsApp, Telegram)
Based on MSC2346
Type of change
Checklist:
Preview: https://713--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️