Add new constructor to let you pass the underline netif (e.g. for PPPoS) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the library works only via WiFi (STA, not in AP mode). That is because all the data is written and read to a fixed "underline netif".
With this PR the application can pass a "struct netif" to the constructor so then the library uses that netif as "underline netif". If "struct netif" is NULL then library use the default WiFi STA netif.
To pass the netif I did a refactor to the constructor: the new constructor accepts just one argument that is a config struct. In the future maybe we can also add the presharedKey easly (now preshardKey is NULL by default and unchangable by the application).
This PR let the application to specify the underline netif, so the application can pass as underline netif a the PPPoS netif.