images/maker: fix building Go deps (again)

[errordeveloper]

There appears to be a subtle difference between go mod download
and go mod download all. This change fixes the following error:

 #25 0.469 + mkdir -p /out/usr/local/bin
 #25 0.471 + go mod download
 #25 86.44 + go build -ldflags '-s -w' -o /out/usr/local/bin/docker-credential-env github.com/errordeveloper/docker-credential-env
 #25 86.50 missing go.sum entry for module providing package github.com/errordeveloper/docker-credential-env; to add:
 #25 86.50 	go mod download github.com/errordeveloper/docker-credential-env

[twpayne]

Is this change correct? I don't see go mod download all mentioned in the documentation for go mod download.

[qmonnet]

The help message says the two commands are equivalent.

$ go help mod download
usage: go mod download [-x] [-json] [modules]

Download downloads the named modules, which can be module patterns selecting
dependencies of the main module or module queries of the form path@version.
With no arguments, download applies to all dependencies of the main module
(equivalent to 'go mod download all').

This file (is it up-to-date?) also seems to indicate that they do the same. I wonder how the two commands actually differ 🤔.

Note that I found this issue that might be relevant with future versions of Go.

[errordeveloper]

This does fix build failure when I tested it, I don't know the issue to be honest, but the docs for this command seem rather limited...

[qmonnet]

Image build is fixed indeed 🎉

[twpayne]

For info, I tested this on a personal repo yesterday evening and found that go mod download all does indeed have different behavior. It populates more of go.sum than a simple go mod download. PR: twpayne/chezmoi#1281.