Skip to content

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Apr 6, 2021

Background:
With router usage and optional target (#512); Required target for http-proxy can sometimes be empty.

This PR will re-throw the error emitted from http-proxy.

req and res object are empty, so there is no graceful way to handle this error...

In these cases it recommended to set target as fallback.

@chimurai chimurai merged commit 030ea2e into master Apr 6, 2021
@chimurai chimurai deleted the fix-error-missing-target branch April 6, 2021 19:24
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 87.302% when pulling 1eb6a85 on fix-error-missing-target into 40e8763 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants