Skip to content

ci(ci.yml): unpin node 24 #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2025
Merged

ci(ci.yml): unpin node 24 #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b788bc
ci(ci.yml): unpin node 24
chimurai Oct 3, 2025
e56e801
chore(package): reinstall mockttp deps
chimurai Oct 5, 2025
9bb985a
build(mockttp): use 2048 bits in generateCACertificate
chimurai Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,7 @@ jobs:

strategy:
matrix:
# Pin v24 for now due to issues with TLS passthrough with mockttp
# https://github.com/httptoolkit/mockttp/commit/b591cff5f44355f395aee5eaf5f2bcc1b1979b34
node-version: [20.x, 22.x, 24.4.1]
node-version: [20.x, 22.x, 24.x]

steps:
- uses: actions/checkout@v5
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/router.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as request from 'supertest';

import { createApp, createAppWithPath, createProxyMiddleware } from './test-kit';

const untrustedCACert = generateCACertificate({ bits: 1024 });
const untrustedCACert = generateCACertificate({ bits: 2048 });

process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';

Expand Down
Loading
Loading