-
-
Notifications
You must be signed in to change notification settings - Fork 99
Description
β I'm submitting a ...
- π tests bug report
- π bug report
- π£ feature request
- β question about the decisions made in the repository
π Describe the bug. What is the current behavior?
pytest 6.2.0 introduced unraisableexception and threadexception modules that are enabled by default. They exploit sys.unraisablehook and threading.excepthook that were introduced in Python 3.8.
This makes pytest emit warnings for unclosed resources and unhandled exceptions that happen in threads when run under Python 3.8.
Our pytest.ini turns those exceptions into errors with filterwarnings = error which results in a failed test run outcome under the conditions described above.
The short-term solution is to patch the filterwarnings setting but in the long-term we need to investigate how to prevent those permanently.
β What is the motivation / use case for changing the behavior?
Green tests.
π‘ To Reproduce
Run tox under Python 3.8+ on master.
π‘ Expected behavior
No errors in CI.
π Details
https://docs.pytest.org/en/stable/usage.html#unraisable
π Environment
- Cheroot version: master
- CherryPy version: N/A
- Python version: 3.8+
- OS: N/A
- Browser: N/A
π Additional context