Bump scaffolding-go, pulling in Go 1.11 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unpins our version of core/scaffolding-go which in turn will pull in the latest version of core/go. All of A2 builds and passes tests with this change in place: https://buildkite.com/chef/chef-a2-master-verify/builds/17409 In the past we had pinned our version of Go to avoid this bug: golang/go#28065 However, rather than pinning, we should track down any places where that is still an issue and either make sure those builds either have gcc available or set GCO_ENABLED=0. Signed-off-by: Steven Danna <[email protected]>
jaym
approved these changes
Nov 16, 2018
|
We probably need to hold off on merging this until we at least have the list of things that are gonna break and what needs to be queued up. I'm working on getting that for us at the moment. |
|
So, I think we've sorted everything in A2 that we can, so really it is just up to when we want to do this AFAIK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unpins our version of core/scaffolding-go which in turn will pull
in the latest version of core/go.
All of A2 builds and passes tests with this change in place:
https://buildkite.com/chef/chef-a2-master-verify/builds/17409
In the past we had pinned our version of Go to avoid this bug:
golang/go#28065
However, rather than pinning, we should track down any places where
that is still an issue and either make sure those builds either have
gcc available or set GCO_ENABLED=0.
Signed-off-by: Steven Danna [email protected]