Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

@TylerAPfledderer
Copy link
Collaborator

Description

Updated the layout of the Canvas preview for storybook

Motivation and Context

The layout is currently broken, where only the Chakra props in the components used are working, and the scoped scss in the style tag of Canvas.vue.

Removed the style tag and all css properties, and used them as props in the chakra components used, along with additional adjustments to ensure the header content doesn't overlap the rendered story content.

How Has This Been Tested?

Ran Storybook with the changes and viewed various stories.

Screenshots (if appropriate):

Before:

image

After:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

⚠️ No Changeset found

Latest commit: 79eb188

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-vue ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 4:37PM (UTC)

@TylerAPfledderer TylerAPfledderer changed the title fix(canvas): update storybook preview layout fix(canvas): update storybook preview decorator Apr 20, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 79eb188:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TylerAPfledderer

@codebender828 codebender828 merged commit 22d60f6 into chakra-ui:develop Jun 13, 2022
@TylerAPfledderer TylerAPfledderer deleted the fix/storybook-canvas-layout branch June 13, 2022 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants