-
Notifications
You must be signed in to change notification settings - Fork 136
feat: Bring Chakra-ui theme API v1 to Vue 2 #466
Conversation
…liable and easy to check
|
|
@simpletrontdip is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f5258e:
|
|
This pull request is being automatically deployed with Vercel (learn more). chakra-ui-vue – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/J2KahxY98VcoPSkdm2MaZ1bu1pdT |
|
Very interesting PR @simpletrontdip 😀 Thanks for taking the initiative on this. since it's relatively big, I will take some time to review it thoroughly. But appreciate the hard work! Will keep you posted here. |
codebender828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work done here, @simpletrontdip 👍🏽
Really impressed. Will be sure to give you a shoutout. I'm curious to see how you and your team are using this library in production. 😀
Will schedule a new minor version release with this change after merging it. If you'd like to continue contributing to Chakra UI Vue, I'd be happy to chat with you since we need more people to help us as we grow!
Cheers, and thanks for the good work.
|
Thanks, @codebender828. |
Support Chakra UI Theme API v1 in Vue 2
Description
@chakra-ui/styled-systemto bring new Theme API to Vue 2configdir, now they are supported by the upstream theme package.@emotion/jest/serializerto enhance snapshot tests@chakra-ui/vue-themeinstead of the relative pathlib/theme/srcMotivation and Context
How Has This Been Tested?
Screenshots:
Update
Sandbox demo for baseStyle here
Types of changes
Checklist:
Not really sure about this, should we link to upstream theme API page