Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

@ejirocodes
Copy link
Contributor

Screen Shot 2021-06-29 at 3 12 54 PM

Screen Shot 2021-06-29 at 3 12 47 PM

… icon

Add isOpen to Vue data object and used to conditionally render chevron icon when <c-menu-button> toggled
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2021

⚠️ No Changeset found

Latest commit: b52d53f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 29, 2021

@ejirocodes is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b52d53f:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@codebender828 codebender828 changed the title Add isOpen to Vue data object and use to conditionally render chevron… feat: Add isOpen to Vue data object and use to conditionally render chevron… Jul 4, 2021
@vercel
Copy link

vercel bot commented Jul 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/zjxPTrKvSSCdW5WujNNDLk3u72Th
✅ Preview: https://chakra-ui-vue-git-fork-ejirocodes-patch-2-chakra-ui.vercel.app

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ejirocodes

Thanks for the initiative on this.

I've requested some changes. See CSB for examples:
https://codesandbox.io/s/chakra-ui-vue-0x-starter-template-forked-nyxf6?file=/src/App.vue

@ejirocodes
Copy link
Contributor Author

@codebender828, I've updated the docs

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ejirocodes 👍🏽

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants