-
Notifications
You must be signed in to change notification settings - Fork 31
Feature/prop types #72
Conversation
🦋 Changeset detectedLatest commit: 1269675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). chakra-ui-vue-next – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next/4axAL5P94UPQyKokkXGFmTuGsCvG chakra-ui-vue-next-playground – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next-playground/7nAy2t1KfUSYKUVuqcnq3TXkLFuk |
|
Which syntax is better? @codebender828 @carwack Right now im using the first syntax which is IMO cleaner/better but the second one is less code to type idk. 1: const CBoxImpl = defineComponent({
// actual implementation
})
// export
export const CBox = CBoxImpl as ComponentWithProps<DeepPartial<BoxProps>>2: //export
export const CBox = defineComponent({
// actual implementation
}) as ComponentWithProps<DeepPartial<BoxProps>> |
Me personally, I prefer nr 1. Because it's cleaner and easier to see what's going on. Great job here! |
codebender828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work here! Thank you @koca
I've offered some suggestions for declaring the component types
…o feature/prop-types
…ue-next into feature/prop-types
codebender828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initial work done here @koca .
Gonna merge this
What is the new behavior?
Type support for all theming and component props.
I've been playing/using this for couple of days already i can say that its a great experience. 🚀
gif:

Does this introduce a breaking change?
btw, you need to use
Volarvscode extension to try this feature.