Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

@Shyrro
Copy link
Contributor

@Shyrro Shyrro commented Sep 29, 2022

Signed-off-by: Shyrro [email protected]

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, a Windows user can't use the repo out of the box, he has to do tricks to use NODE_ENV

What is the new behavior?

Uses cross-env so that if works everywhere

Does this introduce a breaking change?

  • Yes
  • No

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-vue-next ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 4:45PM (UTC)
chakra-ui-vue-next-playground ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 4:45PM (UTC)

@codebender828 codebender828 merged commit 1cc5002 into chakra-ui:develop Sep 30, 2022
TylerAPfledderer added a commit to TylerAPfledderer/chakra-ui-vue-next that referenced this pull request Oct 4, 2022
- remove 4 step in initial setup (not needed in this section)
- remove mention of NODE_ENV for Windows user (was fixed in PR chakra-ui#172)
- add link to `components-guide` for new component building
- mention running `yarn start` before starting the playground server
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants