Skip to content

don't throw wasm compile exception after finishing bytecode gen #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 1 commit into from
Feb 20, 2019
Merged

don't throw wasm compile exception after finishing bytecode gen #5963

chakrabot merged 1 commit into from
Feb 20, 2019

Conversation

@MikeHolman
Copy link
Contributor

@MikeHolman MikeHolman commented Feb 20, 2019

Fixes #5956

@MikeHolman MikeHolman requested a review from meg-gupta February 20, 2019 01:01
@chakrabot chakrabot merged commit a06ebc1 into chakra-core:master Feb 20, 2019
chakrabot pushed a commit that referenced this pull request Feb 20, 2019
@MikeHolman
[MERGE #5963 @MikeHolman] don't throw wasm compile exception after fi…
4a18b8a 
…nishing bytecode gen

Merge pull request #5963 from MikeHolman:badwasmfunc

Fixes #5956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@meg-gupta meg-gupta meg-gupta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeHolman @meg-gupta @chakrabot