OS#13419689 - DOMFastPathGetter instructions do not propagate destination profile data, adding overhead to inlined getter calls #3584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion profile data, adding overhead to inlined getter calls This change addresses the issue of Get/SetElement being used a TypedArrays from the host, which should have specialized calls from the backend. This bug happens because, when the Inliner creates the DOMFastPathGetter instruction to replace a LdFld instruction, it does not propagate dst's profile data. Thus, though DOMFastPathGetter avoids calling into the host, it also introduces a new cost of making generic calls because the type is unknown. This change ensures that the original LdFld's dst profile data is also copied to the new instruction for later type-specific optimizations.
pleath
approved these changes
Aug 24, 2017
chakrabot
pushed a commit
that referenced
this pull request
Aug 25, 2017
…do not propagate destination profile data, adding overhead to inlined getter calls Merge pull request #3584 from thomasmo:domfastpathgetter_dst_profile This change addresses the issue of Get/SetElement being used a TypedArrays from the host, which should have specialized calls from the backend. This bug happens because, when the Inliner creates the DOMFastPathGetter instruction to replace a LdFld instruction, it does not propagate dst's profile data. Thus, though DOMFastPathGetter avoids calling into the host, it also introduces a new cost of making generic calls because the type is unknown. This change ensures that the original LdFld's dst profile data is also copied to the new instruction for later type-specific optimizations.
chakrabot
pushed a commit
that referenced
this pull request
Aug 25, 2017
…tructions do not propagate destination profile data, adding overhead to inlined getter calls Merge pull request #3584 from thomasmo:domfastpathgetter_dst_profile This change addresses the issue of Get/SetElement being used a TypedArrays from the host, which should have specialized calls from the backend. This bug happens because, when the Inliner creates the DOMFastPathGetter instruction to replace a LdFld instruction, it does not propagate dst's profile data. Thus, though DOMFastPathGetter avoids calling into the host, it also introduces a new cost of making generic calls because the type is unknown. This change ensures that the original LdFld's dst profile data is also copied to the new instruction for later type-specific optimizations.
chakrabot
pushed a commit
that referenced
this pull request
Aug 25, 2017
…athGetter instructions do not propagate destination profile data, adding overhead to inlined getter calls Merge pull request #3584 from thomasmo:domfastpathgetter_dst_profile This change addresses the issue of Get/SetElement being used a TypedArrays from the host, which should have specialized calls from the backend. This bug happens because, when the Inliner creates the DOMFastPathGetter instruction to replace a LdFld instruction, it does not propagate dst's profile data. Thus, though DOMFastPathGetter avoids calling into the host, it also introduces a new cost of making generic calls because the type is unknown. This change ensures that the original LdFld's dst profile data is also copied to the new instruction for later type-specific optimizations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the issue of Get/SetElement being used a TypedArrays from the host, which should have specialized calls
from the backend. This bug happens because, when the Inliner creates the DOMFastPathGetter instruction to replace a LdFld
instruction, it does not propagate dst's profile data. Thus, though DOMFastPathGetter avoids calling into the host, it also
introduces a new cost of making generic calls because the type is unknown.
This change ensures that the original LdFld's dst profile data is also copied to the new instruction for later type-specific
optimizations.