Do not peep closure stack symbols #3536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
fixclosure
branch
2 times, most recently
from
96e02ec to
bb752a6
Compare
Contributor
Author
|
This bug came up in swb branch for test32:core\test\Bugs\randomBugs.js. I don't have a repro for without the flags -forceSoftwareWriteBarrier -verifyBarrierBit yet. It requires a specific pattern of register allocation to raise this bug. With the flags, the result of consecutive LdSlotArr s are assigned 2 different registers and peeps optimizes it incorrectly. Without the flags, am unable to repro such a scenario yet. |
LouisLaf
reviewed
Aug 18, 2017
lib/Backend/Peeps.cpp
Outdated
| void | ||
| Peeps::SetReg(RegNum reg, StackSym *sym) | ||
| { | ||
| this->ClearReg(sym->scratch.peeps.reg); |
Collaborator
There was a problem hiding this comment.
this->ClearReg(sym->scratch.peeps.reg); [](start = 3, length = 40)
This should probably move bellow your new code.
Contributor
Author
There was a problem hiding this comment.
You are right, will move this below.
meg-gupta
force-pushed
the
fixclosure
branch
2 times, most recently
from
45cd22a to
660fefc
Compare
Fixes OS#11093413 PeepAssign optimizes away when it says multiple reloads due to LdSlotArr, because these look like spill reloads. We should avoid doing this for closure symbols.
chakrabot
pushed a commit
that referenced
this pull request
Aug 21, 2017
Merge pull request #3536 from meg-gupta:fixclosure
chakrabot
pushed a commit
that referenced
this pull request
Aug 21, 2017
Merge pull request #3536 from meg-gupta:fixclosure
chakrabot
pushed a commit
that referenced
this pull request
Aug 21, 2017
…tack symbols Merge pull request #3536 from meg-gupta:fixclosure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.