Add splash screen, preload images, use native driver #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
changed the title
JedWatson
reviewed
Mar 7, 2017
| }; | ||
|
|
||
| type State = { | ||
| hasScrolled: boolean, |
There was a problem hiding this comment.
what is this being used for? I couldn't see an obvious purpose for tracking it
Author
There was a problem hiding this comment.
unfortunately there is a bug in native scroll driven animations that hasn't been resolved in 0.41 (which exponent is currently using) and it causes the values to not be properly initialized, so I used this as a work around
JedWatson
reviewed
Mar 7, 2017
| <View style={styles.spacer} /> | ||
|
|
||
| <ListView | ||
| <AnimatedListView |
Author
There was a problem hiding this comment.
because it uses a native animated event, it needs to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.