fix: make response valid if either UP or UV flags are present #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
changed the title
sorah
reviewed
Oct 3, 2018
lib/webauthn/authenticator_data.rb
Outdated
|
|
||
| def user_present? | ||
| flags[USER_PRESENT_FLAG_POSITION] == "1" | ||
| flags[USER_PRESENT_FLAG_POSITION] == "1" || user_verified? |
Contributor
There was a problem hiding this comment.
This loses the ability to verify only a UP flag. Changing valid? method to check both might be better?
Contributor
Author
There was a problem hiding this comment.
That's true.
The thing is I wanted to keep this logic contained within AuthenticatorData. I think we can have both things by reworking a bit this methods in AuthenticatorData...
Contributor
Author
There was a problem hiding this comment.
Thank you for your feedback! :-)
grzuy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up should be add some test coverage for this after https://github.com/cedarcode/webauthn-ruby/pull/70/files#diff-eda0ea1702d5d6e57c7f8eed6aa93151R24 is merged.