-
-
Notifications
You must be signed in to change notification settings - Fork 66
Verify topOrigin during credential registration and authentication
#486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
11efc20 to
d57f060
Compare
|
The WebAuthn specification provides several examples of how the top origin can be validated:
This PR doesn't yet allow configuring the allowed top origin dynamically or with unrestricted values. If we want to support those cases, we can address them in a follow-up PR. |
santiagorodriguez96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Leave a couple of thoughts to discuss, but is looking good overall. Perhaps we have to test this with our demos to ensure is working correctly in a real life scenario 👀
After testing locally with two demos, I discovered that we were incorrectly expecting |
29b5369 to
d041277
Compare
d041277 to
687d6cf
Compare
top_origin during credential registration and authenticationtopOrigin during credential registration and authentication
75ceb1f to
e4f0877
Compare
Note
This is a Level 3 feature based on the latest W3C Working Draft
Summary
This PR introduces support for verifying the
top_originparameter reported by the browser during WebAuthn registration and authentication ceremonies.The topOrigin value identifies the top-level origin under which a WebAuthn ceremony is taking place, typically relevant when credentials are created or used within iframes or embedded contexts.
To support this, a new configuration option is added:
If the
top_originreported by the browser is not included inallowed_top_origins, the operation will be rejected.References
Related blogs