-
-
Notifications
You must be signed in to change notification settings - Fork 66
Test against different OpenSSL library versions #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f92a491 to
d4159ec
Compare
758d9f5 to
506f534
Compare
506f534 to
cbb066e
Compare
Those versions do not support OpenSSL 3 so those jobs are failing. For reference: - https://github.com/ruby/openssl/blob/080b21d/README.md#compatibility-and-maintenance-policy - https://www.rubyonmac.dev/openssl-versions-supported-by-ruby
This will make it easier to understand which versions of Ruby and OpenSSL are at first sight.
cbb066e to
ac812d3
Compare
nicolastemciuc
approved these changes
Sep 18, 2025
Member
nicolastemciuc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: ~/rubies/ruby-${{ inputs.version }} | ||
| key: ruby-${{ inputs.version }}-${{ inputs.openssl-version }} |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| key: ruby-${{ inputs.version }}-${{ inputs.openssl-version }} | |
| key: ruby-${{ inputs.version }}-openssl${{ inputs.openssl-version }} |
Co-authored-by: Nicolás Temciuc <[email protected]>
ee5c19c to
380e0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to cedarcode/tpm-key_attestation#49.
Summary
This PR updates our CI to manually install OpenSSL and Ruby so that we can test against different OpenSSL versions, without having to rely on the OpenSSL version that comes with the OS' ruby.