Skip to content

Conversation

@santiagorodriguez96
Copy link
Contributor

Motivation

Similar to cedarcode/tpm-key_attestation#49.

We got a notification that ubuntu-20 images are being deprecated:

https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/#ubuntu-20-image-is-closing-down

After upgrading to ubuntu-22 or ubuntu-24 a lot of tests started to break due to the Rubies on those images coming with OpenSSL version 3+. That means that, by upgrading, we wouldn't have any way of testing against OpenSSL 1.1.1w

We still want to test against OpenSSL 1.1.1w despite it being EOL.

Summary

This PR updates our CI to manually install OpenSSL and Ruby so that we can test against different OpenSSL versions, without having to rely on the OpenSSL version that comes with the OS' ruby.

@santiagorodriguez96 santiagorodriguez96 marked this pull request as draft May 16, 2025 15:11
@santiagorodriguez96 santiagorodriguez96 changed the title Manually install OpenSSL 1.1.1w Test against different OpenSSL library versions May 16, 2025
@santiagorodriguez96 santiagorodriguez96 force-pushed the sr--manually-install-openssl branch from f92a491 to d4159ec Compare May 16, 2025 16:03
@santiagorodriguez96 santiagorodriguez96 force-pushed the sr--manually-install-openssl branch from 758d9f5 to 506f534 Compare September 17, 2025 13:27
@santiagorodriguez96 santiagorodriguez96 force-pushed the sr--manually-install-openssl branch from 506f534 to cbb066e Compare September 17, 2025 14:53
@santiagorodriguez96 santiagorodriguez96 force-pushed the sr--manually-install-openssl branch from cbb066e to ac812d3 Compare September 17, 2025 15:11
@santiagorodriguez96 santiagorodriguez96 marked this pull request as ready for review September 17, 2025 15:11
Copy link
Member

@nicolastemciuc nicolastemciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

uses: actions/cache/restore@v4
with:
path: ~/rubies/ruby-${{ inputs.version }}
key: ruby-${{ inputs.version }}-${{ inputs.openssl-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: ruby-${{ inputs.version }}-${{ inputs.openssl-version }}
key: ruby-${{ inputs.version }}-openssl${{ inputs.openssl-version }}

@santiagorodriguez96 santiagorodriguez96 force-pushed the sr--manually-install-openssl branch from ee5c19c to 380e0d4 Compare September 18, 2025 17:18
@santiagorodriguez96 santiagorodriguez96 merged commit a297440 into master Sep 18, 2025
35 checks passed
@santiagorodriguez96 santiagorodriguez96 deleted the sr--manually-install-openssl branch September 18, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants