Fix bug with referencing non-object types #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebe
force-pushed
the
fix-ref-non-objects
branch
from
9ee5be9 to
d6785f3
Compare
a reference to an array was crashing with an invalid function call. Proper instanceof check has been added in Reference. also creating references in non-object types and Type::ANY is working correctly now. fixes #47
cebe
force-pushed
the
fix-ref-non-objects
branch
from
d6785f3 to
3de06bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a reference to an array was crashing with an invalid function call.
Proper instanceof check has been added in Reference.
also creating references in non-object types and Type::ANY is working
correctly now.
fixes #47