Skip to content

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Mar 18, 2023

Description

This PR runs KICS in parallel to the Megalinter. KICS is a long running linter (up to 4 minutes). We can save roughly 3 minutes if we run it in parallel to Megalinter. So we don't have to wait for Docker to download the Megalinter image.

KICS finishes now before the Megalinter.

Migrations required

No

Verification

Check that the workflow is green.

@github-actions
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.05s
✅ COPYPASTE jscpd yes no 1.03s
✅ JSON eslint-plugin-jsonc 1 0 0 1.14s
✅ JSON jsonlint 1 0 0.2s
✅ JSON prettier 1 0 0 0.43s
✅ JSON v8r 1 0 2.47s
✅ REPOSITORY checkov yes no 19.75s
✅ REPOSITORY devskim yes no 0.68s
✅ REPOSITORY dustilock yes no 0.0s
✅ REPOSITORY gitleaks yes no 0.86s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.92s
✅ REPOSITORY syft yes no 0.27s
✅ SPELL cspell 10 0 2.96s
✅ TERRAFORM checkov 6 0 16.06s
✅ TERRAFORM terraform-fmt 6 0 0 0.27s
✅ TERRAFORM terrascan yes no 8.59s
✅ YAML prettier 2 1 0 0.73s
✅ YAML v8r 2 0 3.18s
✅ YAML yamllint 2 0 0.24s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk changed the title ci: run KICS in parallel ci: run KICS in parallel to Megalinter to gain performance Mar 18, 2023
@kayman-mk kayman-mk merged commit 66cbca1 into main Mar 24, 2023
@kayman-mk kayman-mk deleted the kayman-mk-patch-2 branch March 24, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants