-
-
Notifications
You must be signed in to change notification settings - Fork 348
feat!: allow to set all docker options for the Executor #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch. ## Migrations required YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
## Description Removes the earlier deprecated `runners_pull_policy` variable. Since were making a Major release I thought this one was nice to catch. ## Migrations required YES. Replace the `runners_pull_policy` by `runners_pull_policies`.
761ffb6
to
704785e
Compare
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
Just to check the branch after messed up with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new variable
runners_docker_options
which holds all values for the[runners.docker]
section and makes the single variablesrunners_image
runners_privileged
runners_disable_cache
runners_additional_volumes
runners_shm_size
runners_docker_runtime
runners_helper_image
runners_pull_policy
obsolete.
Migrations required
Yes, as the minimum Terraform version is 1.3.0 to support optional block variables with defaults.
A migration script is provided to restructure the variables. See
/migrations/migrate-to-7-0-0.sh
. Attention Mac users: The script will not work out of the box as thesed
implementation is different. Use a Docker container with Alpine or Ubuntu to run the script.Verification
config.toml
remains unchangedconfig.toml
is valid (use `gitlab-runner verify)The runner starts in both cases and is available in Gitlab. No example tested but used our active configuration at Hapag-Lloyd.