chore: lock gh actions on sha instead of tag #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @npalm! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you have the rights of the code added and agree that it will published under the MIT license. This message was generated automatically. You are welcome to improve it. |
kayman-mk
requested changes
Feb 26, 2023
|
@kayman-mk can you check this tiny PR please? |
kayman-mk
approved these changes
Mar 2, 2023
Yup used a nice tool to generate them. And random check some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A good practice in supply chain security is to have immutable builds. Currently GH tags for actions are mutable, even when a specific tag like x.y.z is used. Therefore, this PR locks the actions on the SHA. Dependabot can update the actions based on SHA, including the comments poitning to the underlying version.
Migrations required
NO
Verification
n/a