-
-
Notifications
You must be signed in to change notification settings - Fork 351
feat: allow different compression algorithms for user data compression #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @NerdyMcNerd! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
The start script compression now supports specifying the algorithm, allowing for gzip or none, improving compatibility with Windows instances.
|
To be more flexible later (e.g. supporting zip compression for Windows), I changed the |
kayman-mk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out and providing a solution for this.
🤖 I have created a release *beep* *boop* --- ## [9.3.0](9.2.4...9.3.0) (2025-10-09) ### Features * allow different compression algorithms for user data compression ([#1332](#1332)) ([f89dc27](f89dc27)) ### Bug Fixes * add missing policies for the autoscaler ([#1328](#1328)) ([99b8605](99b8605)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthias Kay <[email protected]>
Description
Windows workers do not support gzip compressed user data.
This allows turning off gzip compression by setting the new (sub-) variable
compress_start_scriptto false.Migrations required
No - the defaults are the old behavior.
Verification
Deployed the changes as a drop in replacement for version 9.2.4 and verified that the user data script in the launch template is in fact not gzip compressed.
fixes #1331