Skip to content

Conversation

@sebastiansimson
Copy link
Contributor

No description provided.

@aalekz aalekz self-requested a review February 25, 2025 17:19
aalekz
aalekz previously approved these changes Feb 25, 2025
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("class BaseItem {\n");

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary empty line?

public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("class ListItemAuthor {\n");

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary new line?

return OpEnum.fromValue((String)(value));
}
}
} @SerializedName("op")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be on a separate line

@Override
public String toString() {
return String.valueOf(value);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line

return OpEnum.fromValue((String)(value));
}
}
} @SerializedName("op")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be on a separate line

public void setValue(List<ListQueryFilter> value) {
this.value = value;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than one empty line

public int hashCode() {
return Objects.hash(super.hashCode());
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than one empty line

}
return null;
}
public static class Adapter extends TypeAdapter<FieldEnum> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line above

return FieldEnum.fromValue((String)(value));
}
}
} @SerializedName("field")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be on a separate line

}
}
return null;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line

@sebastiansimson sebastiansimson merged commit baca6c0 into master Feb 25, 2025
1 check passed
@sebastiansimson sebastiansimson deleted the feature/lists-api branch February 25, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants