Skip to content

Fix/prematurely closed response body #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastiansimson merged 2 commits into from
May 16, 2022
Merged

Fix/prematurely closed response body #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f062235
check for response error before reading body
sebastiansimson May 6, 2022
090ce57
add test for CastleResponse exception handling
sebastiansimson May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/io/castle/client/model/CastleResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ public class CastleResponse {
private final JsonElement json;

public CastleResponse(Response response) throws IOException {
OkHttpExceptionUtil.handle(response);

code = response.code();
String body = response.body().string();
json = JsonParser.parseString(body);

OkHttpExceptionUtil.handle(response);
}

public boolean isSuccessful() {
Expand Down
14 changes: 14 additions & 0 deletions src/test/java/io/castle/client/CastleExceptionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,20 @@ public void invalidRequestTokenError() {
OkHttpExceptionUtil.handle(response);
}

@Test(expected = CastleApiInvalidRequestTokenException.class)
public void invalidRequestTokenCasleResponseResponseError() throws IOException {
//Given
Response response = new Response.Builder()
.code(422)
.request(new Request.Builder().url("http://localhost").build())
.protocol(Protocol.HTTP_1_1)
.message("Message")
.body(ResponseBody.create("{\"type\": \"invalid_request_token\"}", JsonMediaType))
.build();

new CastleResponse(response);
}

@Test(expected = CastleApiInvalidParametersException.class)
public void invalidParametersError() {
//Given
Expand Down