Skip to content

Conversation

ashpect
Copy link
Contributor

@ashpect ashpect commented Aug 14, 2023

What this PR does / why we need it:

Add checksum for darwin/arm64 for dev-dependencies.

Which issue(s) this PR fixes:

Fixes #1288

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Before the fix :

dependencies.go:83: downloading ytt: not supported on platform darwin/arm64
exit status 1

After the fix :

dependencies.go:175: ytt downloaded
dependencies.go:186: ytt validated
dependencies.go:175: kbld downloaded
dependencies.go:186: kbld validated
dependencies.go:175: vendir downloaded
dependencies.go:186: vendir validated
dependencies.go:175: kapp downloaded
dependencies.go:186: kapp validated
Review Checklist:
  • [x ] Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • [] Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

@ashpect ashpect force-pushed the develop branch 2 times, most recently from 16d663f to a78c740 Compare August 14, 2023 12:32
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neil-hickey neil-hickey merged commit 81f1ea1 into carvel-dev:develop Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Installation commands for Mac M1

3 participants