-
Notifications
You must be signed in to change notification settings - Fork 118
Open
Labels
carvel-acceptedThis issue should be considered for future work and that the triage process has been completedThis issue should be considered for future work and that the triage process has been completeddiscussionThis issue is not a bug or feature and a conversation is needed to find an appropriate resolutionThis issue is not a bug or feature and a conversation is needed to find an appropriate resolutionpriority/important-soonMust be staffed and worked on currently or soon.Must be staffed and worked on currently or soon.
Description
In the current alpha, values from the InstalledPackage are appended to the values of the first templating step, which is quite limiting.
To improve this experience for authors, I propose adding a valuesConfig key to the Package definition. Under this key, authors are able to specify which templating step the values will be included in, and can optionally choose to include the namespace as a value as well. It could look something like this: https://gist.github.com/ewrenn8/5d029c1c0c44b12e957119a10733d45f
Some outstanding thoughts:
- What other values may be useful other than namespace, and what is the best way to include them? One example that was brought up was providing the InstalledPackage name as a data value to the templates. If there is a growing list, making them optional keys could get unwieldy.
- Is there a better way to specify which templating step to include the values in?
Making this issue as a discussion ground for potential solutions to this problem, so if there are completely unrelated solutions please post them!
praveenrewar, vrabbi, st3v and MAHDTechMAHDTechMAHDTech
Metadata
Metadata
Assignees
Labels
carvel-acceptedThis issue should be considered for future work and that the triage process has been completedThis issue should be considered for future work and that the triage process has been completeddiscussionThis issue is not a bug or feature and a conversation is needed to find an appropriate resolutionThis issue is not a bug or feature and a conversation is needed to find an appropriate resolutionpriority/important-soonMust be staffed and worked on currently or soon.Must be staffed and worked on currently or soon.
Type
Projects
Status
Prioritized Backlog